iMac RAM upgrade or new 2019 iMac?

There are some experiences (incl. mine) with rehab of older macs in this thread

I’d replace the HD & keep it…but it does look ok acc. to the diagnostics you posted…