What I think is that the comments on most sites are a bit strange, at least the ones comparing ipads to laptops (and yes most of that is apple’s own fault)
I think you should compare the device to what it is supposed to do in your life, and judge whether that then fits the brief.
For me the iPad pro is fully there. Ever since 2015 I’ve switched more and more of my workflow to the iPad and have not looked back. I really love this device, and even more since I got my ipad pro 2018. It’s just a joy to use. I think I get more work done on an ipad than on a desktop device, and most of it is due to the experience of the device with iOS and the distraction free environment.
In my workflow the fact that I always have 100% of the tools within an arms length is the game changer. I don’t have to go to a desktop for this, and use my iPad for that; it all happens on the iPad. Sure, I have wishes for iOS, but I have those for MacOS as well. It’s all about which tool makes me most productive and allows me to have the most fun.
And that’s the iPad pro.
And yes, I still have a mac mini doing a few background tasks, but I also had that when I still used a macbook pro. (like automatic file naming, moving and tagging)